NTP: discard corrupted NTP response #536

pennam · 2025-03-28T10:05:01Z

No description provided.

codecov · 2025-03-28T10:07:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (501271b) to head (f6f4468).
Report is 24 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          33       33           
  Lines        1521     1521           
=======================================
  Hits         1451     1451           
  Misses         70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-03-28T10:32:57Z

Memory usage change @ f6f4468

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_edge:edge_control`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_giga:giga`	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nano:nanorp2040connect`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nicla:nicla_vision`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_opta:opta`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`esp32:esp32:esp32`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`esp8266:esp8266:huzzah`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`rp2040:rp2040:rpipicow`	🔺 +8 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ArduinoIoTCloud-Advanced` flash	%	`examples/ArduinoIoTCloud-Advanced` RAM for global variables	%	`examples/ArduinoIoTCloud-Basic` flash	%	`examples/ArduinoIoTCloud-Basic` RAM for global variables	%	`examples/ArduinoIoTCloud-Callbacks` flash	%	`examples/ArduinoIoTCloud-Callbacks` RAM for global variables	%	`examples/utility/ArduinoIoTCloud_Travis_CI` flash	%	`examples/utility/ArduinoIoTCloud_Travis_CI` RAM for global variables	%	`examples/ArduinoIoTCloud-DeferredOTA` flash	%	`examples/ArduinoIoTCloud-DeferredOTA` RAM for global variables	%	`examples/ArduinoIoTCloud-Notecard` flash	%	`examples/ArduinoIoTCloud-Notecard` RAM for global variables	%	`examples/ArduinoIoTCloud-Schedule` flash	%	`examples/ArduinoIoTCloud-Schedule` RAM for global variables	%	`examples/utility/Provisioning` flash	%	`examples/utility/Provisioning` RAM for global variables	%	`examples/utility/SelfProvisioning` flash	%	`examples/utility/SelfProvisioning` RAM for global variables	%
`arduino:esp32:nano_nora`	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0
`arduino:mbed_edge:edge_control`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_giga:giga`	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nicla:nicla_vision`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_opta:opta`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	0	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0					0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	16	0.01	0	0.0					0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkr1000`	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0					0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0					0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0					0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`esp32:esp32:esp32`	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0
`esp8266:esp8266:huzzah`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0									0	0.0	0	0.0
`rp2040:rp2040:rpipicow`	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/ArduinoIoTCloud-Notecard<br>flash,%,examples/ArduinoIoTCloud-Notecard<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_giga:giga,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,,,,,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkr1000,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,0,0.0,0,0.0,,,,,,,,
rp2040:rp2040:rpipicow,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,

pennam added 2 commits March 28, 2025 11:03

NTP: discard corrupted NTP response

b135201

NTP: remove spaces

f6f4468

per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Mar 28, 2025

pennam requested a review from andreagilardoni April 3, 2025 07:29

andreagilardoni approved these changes Apr 3, 2025

View reviewed changes

pennam merged commit 7120482 into arduino-libraries:master Apr 10, 2025
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NTP: discard corrupted NTP response #536

NTP: discard corrupted NTP response #536

pennam commented Mar 28, 2025

codecov bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025

NTP: discard corrupted NTP response #536

NTP: discard corrupted NTP response #536

Conversation

pennam commented Mar 28, 2025

codecov bot commented Mar 28, 2025 • edited Loading

Codecov Report

github-actions bot commented Mar 28, 2025

codecov bot commented Mar 28, 2025 •

edited

Loading